Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations): Add region comment button in toolbar #1183

Merged
merged 9 commits into from
Mar 27, 2020
Merged

feat(annotations): Add region comment button in toolbar #1183

merged 9 commits into from
Mar 27, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Mar 24, 2020 •
edited
Loading

region-comment
region-comment-active

  • Tests
  • TypeScript
  • SUIT styles

@mxiao6 mxiao6 requested a review from a team as a code owner March 24, 2020 22:32
jstoffan
jstoffan reviewed Mar 24, 2020
View reviewed changes
src/lib/AnnotationControls.js Outdated Show resolved Hide resolved
src/lib/AnnotationControls.js Outdated Show resolved Hide resolved
src/lib/AnnotationControls.js Outdated Show resolved Hide resolved
src/lib/Controls.scss Outdated Show resolved Hide resolved
src/lib/Preview.js Outdated Show resolved Hide resolved
src/lib/viewers/doc/DocBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/image/ImageBaseViewer.js Outdated Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the add-annotations-toolbar branch 2 times, most recently from 02ebcc6 to dbba2b7 Compare March 26, 2020 16:44
jstoffan
jstoffan reviewed Mar 26, 2020
View reviewed changes
src/lib/AnnotationControls.scss Outdated Show resolved Hide resolved
src/lib/AnnotationControls.scss Outdated Show resolved Hide resolved
src/lib/Preview.scss Outdated Show resolved Hide resolved
src/lib/icons/icons.js Outdated Show resolved Hide resolved
src/lib/viewers/doc/DocBaseViewer.js Outdated Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the add-annotations-toolbar branch from 8365a57 to a1ba9ae Compare March 26, 2020 21:19
jstoffan
jstoffan previously approved these changes Mar 26, 2020
View reviewed changes
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the add-annotations-toolbar branch from 4b431b3 to 69cc424 Compare March 26, 2020 22:09
jstoffan
jstoffan previously approved these changes Mar 26, 2020
View reviewed changes
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 04ea830 into box:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxiao6 @jstoffan